Team collaboration (4/6): web i18n keys - #5282
Conversation
Adds the translation keys the team-collaboration UI uses — share-to-team, the read-only notice, the workspace switcher, and the cloud sign-in callout — to the typed dictionary and all locale files. Split out first so the UI PRs that follow carry only their components.
lefarcen
added
size/M
|
Quick PR-body pass: splitting the i18n layer out ahead of the UI PRs makes the stack easier to review. Could you add the missing Why, What users will see, and Validation context? The surface-area section is already there, so this should just be a short reshape of the current summary plus what you ran. |
Visual regression reviewHead:
0 changed · 0 unchanged · 53 new without baseline · 0 failed New cases without baselines
33 additional new case(s) omitted from this comment. Visual diff is advisory only and does not block merging. |
mrcfps
left a comment
mrcfps
left a comment
There was a problem hiding this comment.
@lefarcen I reviewed the changed i18n ranges across Dict and all registered locale dictionaries. The new team-collaboration keys are consistently added in every locale file, the typed dictionary is updated in the matching groups, and the dependency-free key-presence check passed for all 19 locale files. I also attempted the focused web typecheck, but this Looper worktree has no node_modules, so it fails before reaching these changes due missing workspace dependencies. Thanks for splitting this out cleanly ahead of the UI work; it keeps the stacked review focused.
|
Rolled into the (2/3) web PR #5283 — i18n now reviewed with the in-project UI. |
2 participants
Stacks on (3/6). Split out first so the UI PRs carry only their components.
Adds the translation keys the team-collaboration UI uses — share-to-team, the read-only notice, the workspace switcher, and the cloud sign-in callout — to the typed dictionary and all locale files.
Surface area